Rev. 35882 compile problem (Visual C++ 2008 Express)

[arablizzard2413]

I keep getting this error when I try and build the project, if I disable the saga engine then it works fine.

23>Compiling resources...
23>Microsoft (R) Windows (R) Resource Compiler Version 6.1.6723.1
23>Copyright (C) Microsoft Corporation. All rights reserved.
23>Linking...
23>Generating code
23>c:\users\andrew\workbench\scummvm\engines\saga\sndres.cpp(340) : error C2220: warning treated as error - no 'executable' file generated
23>c:\users\andrew\workbench\scummvm\engines\saga\sndres.cpp(340) : warning C4701: potentially uninitialized local variable 'rate' used
23>c:\users\andrew\workbench\scummvm\engines\saga\sndres.cpp(344) : warning C4701: potentially uninitialized local variable 'size' used
23>LINK : fatal error LNK1257: code generation failed
23>Build log was saved at "file://c:\Users\Andrew\workbench\scummvm\dists\msvc9\scummvm_Release\BuildLog.htm"
23>scummvm - 2 error(s), 2 warning(s)
========== Build: 22 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========

[sev]

Forum Rule #3a. There is a bugtracker for such reports.


Eugene

[md5]

I keep getting this error when I try and build the project, if I disable the saga engine then it works fine.

23>Compiling resources...
23>Microsoft (R) Windows (R) Resource Compiler Version 6.1.6723.1
23>Copyright (C) Microsoft Corporation. All rights reserved.
23>Linking...
23>Generating code
23>c:\users\andrew\workbench\scummvm\engines\saga\sndres.cpp(340) : error C2220: warning treated as error - no 'executable' file generated
23>c:\users\andrew\workbench\scummvm\engines\saga\sndres.cpp(340) : warning C4701: potentially uninitialized local variable 'rate' used
23>c:\users\andrew\workbench\scummvm\engines\saga\sndres.cpp(344) : warning C4701: potentially uninitialized local variable 'size' used
23>LINK : fatal error LNK1257: code generation failed
23>Build log was saved at "file://c:\Users\Andrew\workbench\scummvm\dists\msvc9\scummvm_Release\BuildLog.htm"
23>scummvm - 2 error(s), 2 warning(s)
========== Build: 22 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========

I've fixed this now, but next time please file a proper bug report for bugs, as sev said (refer to forum rule #3a). Don't post bugs in the forums

[arablizzard2413]

Sorry, I didn't realize it was a bug, I thought I was just doing something wrong.

[md5]

Sorry, I didn't realize it was a bug, I thought I was just doing something wrong.

Well, it's not a bug in the code per se, it's just Visual Studio being paranoid. I've left it to be paranoid, cause sometimes it catches legitimate cases of unitialised variables