Tinsel MP3/OGG/FLAC support beta test

jimi · Post by **jimi** » Wed Jul 01, 2009 12:54 pm

Hi there,

I just implemented MP3/OGG/FLAC support into the tinsel (Discworld 1&2) engine. Currently it only works on Discworld 1, because I need to decode the audio data of Discworld 2.

Anyway, I would like to have some people test it out before I submit the patch. Anyone in here willing to do so?

Regards
Jimi

fingolfin · Post by **fingolfin** » Wed Jul 01, 2009 1:14 pm

Sounds great, nice

.

However, I would recommend that you just submit the patch anyway; that way, more people can easily beta test it, and moreover ScummVM devs can review it and give feedback on it, too. Like, we can check whether you comply to our code formatting guidelines, and maybe suggest ways to improve it.

I think that way will be much quicker overall.

jimi · Post by **jimi** » Wed Jul 01, 2009 8:46 pm

Just uploaded it. It now works on DiscWorld2 (German) as well. Had to implement ADPCM 6-bit decoding.

btw. I'm copying the first 5000 bytes of *.smp into the compressed version so that detection still works. Also I'm using the first index for MP3/OGG/FLAC detection, this shouldn't hurt, because DW1 and DW2 never use it and I'm patching it back to 0 even in the engine code.

I tried to stay as close to the original code formatting as possible. Also I got really frustrated searching for a diff utility under win32 that is able to create patches.

Anyone interested in SCI mp3/ogg/flac support?

Regards
Jimi

ezekiel000 · Post by **ezekiel000** » Wed Jul 01, 2009 9:05 pm

jimi wrote: Anyone interested in SCI mp3/ogg/flac support?

Shouldn't that wait for the engine to stabilise?

Oh and thank you for adding compression to DW1&2

jimi · Post by **jimi** » Thu Jul 02, 2009 6:34 am

ezekiel000 wrote:
jimi wrote: Anyone interested in SCI mp3/ogg/flac support?
Shouldn't that wait for the engine to stabilise?

a resource.aud compressing utility isn't that much of a problem and the sound code seems to already work just fine. I wouldn't of course compress samples within resource.0*, because those are already compressed and it wouldn't save much discspace anyway.

ezekiel000 · Post by **ezekiel000** » Thu Jul 02, 2009 10:52 am

Oh right that's good then, I'm not a programmer but I keep up with the svn developments (quite a lot goes over my head

)

KuroShiro · Post by **KuroShiro** » Thu Jul 02, 2009 11:12 am

jimi wrote:
ezekiel000 wrote:
jimi wrote: Anyone interested in SCI mp3/ogg/flac support?
Shouldn't that wait for the engine to stabilise?
a resource.aud compressing utility isn't that much of a problem and the sound code seems to already work just fine. I wouldn't of course compress samples within resource.0*, because those are already compressed and it wouldn't save much discspace anyway.

Though I certainly can't speak for the developers... having fooled around with various SCI games in ScummVM, I can say that the audio code on games that are large enough where compression would be worth it is very much still a work in progress. It works very well on SCI0 games, but not so well on newer games. Though who knows, maybe converting would actually simplify things.

jimi · Post by **jimi** » Thu Jul 02, 2009 11:37 pm

KuroShiro wrote: Though I certainly can't speak for the developers... having fooled around with various SCI games in ScummVM, I can say that the audio code on games that are large enough where compression would be worth it is very much still a work in progress. It works very well on SCI0 games, but not so well on newer games. Though who knows, maybe converting would actually simplify things.

Did you try the latest SVN builds? King's Quest 5&6 are working quite nicely. And those are both full talkie versions, perfect for audio compression.

KuroShiro · Post by **KuroShiro** » Fri Jul 03, 2009 2:47 am

jimi wrote:
KuroShiro wrote: Though I certainly can't speak for the developers... having fooled around with various SCI games in ScummVM, I can say that the audio code on games that are large enough where compression would be worth it is very much still a work in progress. It works very well on SCI0 games, but not so well on newer games. Though who knows, maybe converting would actually simplify things.
Did you try the latest SVN builds? King's Quest 5&6 are working quite nicely. And those are both full talkie versions, perfect for audio compression.

Actually, two of the games I was referring to were my old CDs of KQ5 and 6 (as well as SQ4, QFG3). The speech plays pretty well, but the music sometimes plays too loudly or quietly, badly out of tune, or extremely slowly. Though I suppose that was about a week and ago so maybe it has been fixed up a bit since then. If so that is some nice progress.

ezekiel000 · Post by **ezekiel000** » Sat Jul 04, 2009 1:15 pm

Would there be a possibility or any gain from compressing the bmv files of DW2?

SithlordDK · Post by **SithlordDK** » Mon Jul 06, 2009 5:29 pm

Can someone explain to me why I always get a "cannot open file: english.smp.idx" when I try to compress the "ENGLISH.SMP" (from the german version).

ezekiel000 · Post by **ezekiel000** » Mon Jul 06, 2009 6:00 pm

you don't need to have the .smp on when you specify the filename.

MarkCoolio · Post by **MarkCoolio** » Sun Sep 06, 2009 11:55 am

Would it be possible to auto-rename the resulting compressed.smp and compressed.idx back to the original filename, let's say ENGLISH.SMP or GERMAN1.SMP/GERMAN1.IDX and so on?
Guess they have to be named like that again cos in Discworld 2 the 2 Speechfiles would otherwise be both named "compressed.smp" (which of course would not work in one directory

)..
Thx in advance

KuroShiro · Post by **KuroShiro** » Sun Sep 06, 2009 4:50 pm

MarkCoolio wrote:Would it be possible to auto-rename the resulting compressed.smp and compressed.idx back to the original filename, let's say ENGLISH.SMP or GERMAN1.SMP/GERMAN1.IDX and so on?
Guess they have to be named like that again cos in Discworld 2 the 2 Speechfiles would otherwise be both named "compressed.smp" (which of course would not work in one directory )..
Thx in advance

Once you've compressed it, you don't need the original any more as far as I can tell, though it isn't documented yet. Just rename the compressed file to be what the original was.