Request for Enhancement

[Serious Callers Only]

Could the mass add function (or the add) not add a game if the required files are incomplete?

[Serious Callers Only]

Changing subject -
Broken Sword 2 really doesn't want to be portable...
I managed to make original game work on wine with a "fake drive" (to allow scummvm to work at the same time with symlinks) however the registry entries of it are defeating me. I'm sure there is one hidden (probably the value is cyphered) registry entry that controls the location of the exe or something. This is what i have now.

#!/bin/bash
GAME_PATH=$(dirname "$(readlink -f "$0")")
if [ -d ~/.wine/ ];
then
cd ~/.wine/dosdevices
rm -f x: x::
rm -f f: f::
else
wineboot
wineserver -w
cd ~/.wine/dosdevices
fi
##This game is extracted to the normal filesystem so scummvm can work with it
##with a few additional symlinks
##and is mounted by wine as a cdrom so it can run the original exe too
##however, for this to work, wine needs two files in the root of each "CD"
##.windows-serial and .windows-label and a registry entry saying it is a CD.
ln -s "$GAME_PATH/Broken Sword 2/CD1" "f:"
wine reg add "HKLM\\Software\\Wine\\Drives" /v "f:" /t REG_SZ /d "cdrom"
ln -s "$GAME_PATH/Broken Sword 2/CD2" "x:"
wine reg add "HKLM\\Software\\Wine\\Drives" /v "x:" /t REG_SZ /d "cdrom"
##registry key needed
wine reg add "HKLM\\Software\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\Broken Sword II" /v "State" /t REG_SZ /d "Complete"
#wine reg add "HKLM\\Software\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\Broken Sword II" /v "DisplayName" /t REG_SZ /d "Broken Sword II"
wine reg add "HKLM\\Software\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\Broken Sword II" /v "UninstallString" /t REG_SZ /d "$GAME_PATH/Broken Sword 2/uninstal.exe"
#wine reg add "HKLM\\Software\\Revolution Software Ltd\\Broken Sword\\2.0"

wineserver -w
wine "$GAME_PATH/Broken Sword 2/Sword2.exe"

The two registry entries besides the cd are needed to get the Sword2 menu to work, however neither the "Play Broken Sword II" button nor the "View Credits" work.

Comparing the registry of a clean wine and one after the install of BSII gives a lot of differences...

[eriktorbjorn]

Could the mass add function (or the add) not add a game if the required files are incomplete?

You mean verify each and every one of the game's data files? That sounds like quite a bit of work, if it's a game like The Feeble Files which has 1000+ data files, and that's not even counting the 200+ cutscene movie files.

[Serious Callers Only]

Could the mass add function (or the add) not add a game if the required files are incomplete?

You mean verify each and every one of the game's data files? That sounds like quite a bit of work, if it's a game like The Feeble Files which has 1000+ data files, and that's not even counting the 200+ cutscene movie files.

Oh. I am requesting because as i put the cd contents next to the install of broken sword it started mass-adding 6 "games" when mass added: sword2, sword2-demo, sword2-1, sword2-1-demo, sword2-2, sword2-2-demo
or something similar. (Sword2-1 actually works, but not for long i'd bet).

I thought you already collected the info, since it distinguished them.

[eriktorbjorn]

Oh. I am requesting because as i put the cd contents next to the install of broken sword it started mass-adding 6 "games" when mass added: sword2, sword2-demo, sword2-1, sword2-1-demo, sword2-2, sword2-2-demo
or something similar. (Sword2-1 actually works, but not for long i'd bet).

Ah. Well, that sounds like this bug, then.

[Serious Callers Only]

Managed to make it "work" by giving up on the launcher. The game only needs to be invoked on the correct dir.

#!/bin/bash
GAME_PATH=$(dirname "$(readlink -f "$0")")
if [ -d ~/.wine/ ];
then
cd ~/.wine/dosdevices
rm -f x: x::
rm -f f: f::
else
wineboot
cd ~/.wine/dosdevices
fi
##This game is extracted to the normal filesystem so scummvm can work with it
##with a few additional symlinks
##and is mounted by wine as a cdrom so it can run the original exe too
##however, for this to work, wine needs two files in the root of each "CD"
##.windows-serial (containing the serial number of your copy) and .windows-label (containing the label of your copy) and a registry entry saying it is a CD.
ln -s "$GAME_PATH/Broken Sword 2/CD1" "f:"
wine reg add "HKLM\\Software\\Wine\\Drives" /v "f:" /t REG_SZ /d "cdrom"
ln -s "$GAME_PATH/Broken Sword 2/CD2" "x:"
wine reg add "HKLM\\Software\\Wine\\Drives" /v "x:" /t REG_SZ /d "cdrom"
##registry keys needed for the launcher, but fortunatly not for the game. Just cd into the dir
wineserver -w
cd "$GAME_PATH/Broken Sword 2/"
wine "Game.exe"

[Serious Callers Only]

Oh. I am requesting because as i put the cd contents next to the install of broken sword it started mass-adding 6 "games" when mass added: sword2, sword2-demo, sword2-1, sword2-1-demo, sword2-2, sword2-2-demo
or something similar. (Sword2-1 actually works, but not for long i'd bet).

Ah. Well, that sounds like this bug, then.

I was not surprized when it happened.
My folder structure is now:
broken sword 2
-symlinks
-CD1
-CD2

So it kinda makes sense that "mass add" on the topmost dir would identify 3*(gamefiles+demos) = 6 games.

Something like this happened with Legend of Kyrandia, Malcom's Revenge to me (i'm using a similar trick there).

And for some reason, gold rush is being identified as a "AGI fanmade game".

[md5]

And for some reason, gold rush is being identified as a "AGI fanmade game".

That happens with cracked versions of the game

[Serious Callers Only]

Thanks. I thought you blacklisted them?

[md5]

Thanks. I thought you blacklisted them?

Indeed, we did, apart from that version, thanks for pointing that out!

[Serious Callers Only]

Need a md5?

BTW, i've been meaning to ask, you'll warn the user if he installed one of the Rising Sun patches for instance or you're going to memory patch them just like the original scripts? Also applies to the subtitle patch of GK2 and the full install patches of phantasmagoria (it merges the resources files i think) and others. This is pretty good functionality if you want to run the originals.

[md5]

Need a md5?

BTW, i've been meaning to ask, you'll warn the user if he installed one of the Rising Sun patches for instance or you're going to memory patch them just like the original scripts? Also applies to the subtitle patch of GK2 and the full install patches of phantasmagoria (it merges the resources files i think) and others. This is pretty good functionality if you want to run the originals.

Please supply an md5 yeah

As for the NRS patches, yes, we do warn when they are present, as the issues they address (mostly timer issues) don't exist in ScummVM, and some of them are doing a bit of big changes. Some are quite useful, and are included in ScummVM itself, e.g. the intro speed glitch in a version of PQ2 (which is due to a variable having the wrong value initially), and the simultaneous speech and subtitles support for SQ4CD. GK2 isn't supported yet, so we don't know about that one yet.

[Serious Callers Only]

ce6d51ac9a48a7eb0a2aa94827b9e850 AGI
940144fea8dce843eb56e61f1793ca9f AGIDATA.OVL
dbf46c59c825dd160c523497efb90dd9 CGA_GRAF.OVL
931a099c9c2325ffbc1c4b89349884bb EGA_GRAF.OVL
cabfa2dd4ac12abef8ac740a8dbf1e06 EXIST.COM
7e4d24af6d6478e70af766942324b618 GR122388.QA
f94488d7dc93be247151eb9f5503cbf0 _GR.BAT
3ae052117feb483f01a9017025fbb366 GRDIR
099cf878595fea15a4b2506d40b8ea53 GRVOL.0
8ddf79efdb570d3f56e6fc693ac916a3 GRVOL.1
e2291ecbc0ddc036eb15ce2ac3417116 GRVOL.10
eea575e47b1e8fbd915ed34b68ee17c9 GRVOL.11
0649df472c193ca624dbe5f1327d357e GRVOL.12
0dcb93d9e2901a8b41035812305ed135 GRVOL.2
0cacd4aef3c9e3e9135166c8365ae262 GRVOL.3
9e3e470c693a1bfbf545e5fc1bde7982 GRVOL.4
6d6e1231594b8b5041aa8af64b13a161 GRVOL.5
7b44a218c8ec630c96d9d452e51f43b3 GRVOL.9
c12f3c4cc0a11230c126d0de4c35c293 HGC_GRAF.OVL
d861bc9b6044327d6fc3db63874986b6 _INSTALL.BAT
5c10fbfc50be808c54b74d50cee4ff41 INSTALLH.BAT
38bd521db6e73a0960b5bc77bb19f2d8 JR_GRAF.OVL
5608ad74bcf35065dfe292ed7fd78e2c MAKEPATH.COM
9fa64d3f27c489933c6d9700e94f1791 OBJECT
950bfd0db1aa9fba4289a92ad2612780 RESETDSK.COM
041ea3e2ec7f369b8c6415d166214d9f SIERRA.COM
e99aba825bf3545a113c3fde619f98f6 VG_GRAF.OVL
ce085fc2ef513d084c4396d29ab5086b WORDS.TOK