SCUMM TODO - Shrink MD5 size

[mrugiero]

Hi, I've been looking at the SCUMM engine ToDo list, and there is an item which seems almost trivial to solve.
The approach I propose (and I volunteer myself to provide the patches after the data is gathered) is to temporarily add two or three extra lines on the game detection, so they compute the MD5 with the first 5000 bytes, the first 80KB and then prints in a file named "MD5 computed with 1MB".log a line with the MD5 computed with 5000 bytes and another line with the MD5 computed with 80KB. What would this be for? To gather the new checksums, so I can later update the tables with the new values, after checking if there are or not any collisions with 5000 bytes. If there are collisions, I'll update the tables with the 80KB checksums. Users would only need to run the detection for their games and submit the newly created files. The location should probably be the one where the game is, or maybe a specified directory within SCUMMVM configuration files, something like "~/.config/scummvm/md5_checksums/".
What do you think? I'd like this to be my first contribution because, well, it seems really easy to achieve.

[Raziel]

I'd advise you to come to IRC

chat.freenode.net - #scummvm

and talk to the devs about your proposition directly.

Forums are slow

[clone2727]

I don't think you understand how untrivial it is to track down all those variants.

[md5]

As clone2727 said, it's a major pain to track down all these variants, so it's probably a very difficult task. On the other hand, it could be viable to hardcode the detection size in each detection entry, and detection entries can be updated progressively without breaking compatibility