Double Mouse Cursor - Solved in Android 8

Subforum for discussion and help with ScummVM's Android port

Moderator: ScummVM Team

Post Reply
gregoryoyork
Posts: 1
Joined: Sat Jun 09, 2018 7:49 pm

Double Mouse Cursor - Solved in Android 8

Post by gregoryoyork »

I haven't seen this on the forums, and I know this has been a problem.

Anyone using Android TV or a Chromebook has this issue. Starting with 8.0, the Android port of ScummVM can use the requestPointerCapture feature, allowing the standard cursor to be replaced by the application's cursor.
Dragoth
Posts: 2
Joined: Wed Nov 14, 2018 7:51 am

Re: Double Mouse Cursor - Solved in Android 8

Post by Dragoth »

gregoryoyork wrote: Thu Aug 30, 2018 9:51 pm I haven't seen this on the forums, and I know this has been a problem.

Anyone using Android TV or a Chromebook has this issue. Starting with 8.0, the Android port of ScummVM can use the requestPointerCapture feature, allowing the standard cursor to be replaced by the application's cursor.
Is this already the case (can't find any commits stating that it is), or does this still need to be implemented?

This might be somewhat naive to ask, but:
If it needs to be implemented, could somebody point me to the right repository or possibly even the file where this could/should be done?
e.g.: https://github.com/scummvm/scummvm/tree ... rm/android ?

I haven't developed for Android in quite some time, but would be willing to try...
digitall
ScummVM Developer
Posts: 1177
Joined: Thu Aug 02, 2012 1:40 pm

Re: Double Mouse Cursor - Solved in Android 8

Post by digitall »

Dragoth: A quick search of the website and wiki would have thrown up this...
https://wiki.scummvm.org/index.php/Developer_Central
https://wiki.scummvm.org/index.php?titl ... ng_ScummVM
https://wiki.scummvm.org/index.php?titl ... VM/Android
https://wiki.scummvm.org/index.php?titl ... ndroid-SDL

The SDL based backend is the newer one... Submissions for patches as Github Pull Requests as you indicate.
Dragoth
Posts: 2
Joined: Wed Nov 14, 2018 7:51 am

Re: Double Mouse Cursor - Solved in Android 8

Post by Dragoth »

digitall wrote: Thu Nov 15, 2018 2:30 pm Dragoth: A quick search of the website and wiki would have thrown up this...
I already found your linked docs/tutorials beforehand- i was just hoping that maybe a developer had some idea how to implement it and could point me in the right direction. Nevertheless, thanks for your post! (no sarcasm)

I had some time to read through some of the source in the android port of ScummVM and have some ideas. Once i get a little free time I'll make a pullrequest.

For anyone else interested:

From androidpolice: https://www.androidpolice.com/2017/05/1 ... e-pointer/
...using the new requestPointerCapture method. This will cause the on-screen pointer to disappear, and all mouse events will be transmitted to the application.
Android will automatically release the pointer capture if the app is closed or otherwise loses focus.

Android documentation: https://developer.android.com/training/ ... er-capture
digitall
ScummVM Developer
Posts: 1177
Joined: Thu Aug 02, 2012 1:40 pm

Re: Double Mouse Cursor - Solved in Android 8

Post by digitall »

No problem. Will look forward to any Pull Requests :)
User avatar
SubElement
Posts: 17
Joined: Sun Oct 20, 2013 2:30 pm

Re: Double Mouse Cursor - Solved in Android 8

Post by SubElement »

Sorry to bring up a year old thread, but was this ever implemented?

I'm running this on my ShieldTV and I am still seeing double cursors in ScummVM.
ccawley2011
Posts: 17
Joined: Sat Feb 03, 2018 3:45 pm

Re: Double Mouse Cursor - Solved in Android 8

Post by ccawley2011 »

SubElement wrote: Mon Oct 14, 2019 5:52 am Sorry to bring up a year old thread, but was this ever implemented?

I'm running this on my ShieldTV and I am still seeing double cursors in ScummVM.
Can you give this PR a try, and see if that fixes the issue?
User avatar
SubElement
Posts: 17
Joined: Sun Oct 20, 2013 2:30 pm

Re: Double Mouse Cursor - Solved in Android 8

Post by SubElement »

ccawley2011 wrote: Tue Oct 15, 2019 4:09 pm
SubElement wrote: Mon Oct 14, 2019 5:52 am Sorry to bring up a year old thread, but was this ever implemented?

I'm running this on my ShieldTV and I am still seeing double cursors in ScummVM.
Can you give this PR a try, and see if that fixes the issue?
Would I have to compile this myself? If so, I don't know how sorry.
marcselman
Posts: 1
Joined: Sat Jul 25, 2020 11:52 am

Re: Double Mouse Cursor - Solved in Android 8

Post by marcselman »

It looks like the pull request has already been merged in the master branch.
I'm running ScummVM version 2.1.1 in RetroArch on an Nvidia Shield TV (2019 version) but there the issue still persists.
Maybe, when I can find some time, I'll try to make a custom build with some logging etc. to see if I can find a solution.
But I hope someone else can find a fix since I'm not experienced with Android development.
User avatar
Praetorian
ScummVM Developer
Posts: 884
Joined: Tue May 08, 2007 8:54 am
Location: Greece
Contact:

Re: Double Mouse Cursor - Solved in Android 8

Post by Praetorian »

marcselman wrote: Sun Jul 26, 2020 6:01 pm It looks like the pull request has already been merged in the master branch.
I'm running ScummVM version 2.1.1 in RetroArch on an Nvidia Shield TV (2019 version) but there the issue still persists.
Maybe, when I can find some time, I'll try to make a custom build with some logging etc. to see if I can find a solution.
But I hope someone else can find a fix since I'm not experienced with Android development.
If you have the time and the motivation (and since you also own a device where the bug fix did not work), then go for it.

I've been meaning to look into this issue again, but there are other tasks that have priority over it and, since progress on the port is very slow as of late, any help is much appreciated.

Also, I would not call myself an experienced Android developer either :)

If you are familiar with Docker, I'm maintaining a Docker image with the (latest) Android toolchain set up here:
https://github.com/antoniou79/scummvm-android
Post Reply