[Solved] Broken Sword 1+2: game data not found after ScummVM restart

Ask for help with ScummVM problems

Moderator: ScummVM Team

Post Reply
User avatar
adventurefan
Posts: 10
Joined: Sat Mar 25, 2023 12:18 pm
Location: Germany

[Solved] Broken Sword 1+2: game data not found after ScummVM restart

Post by adventurefan »

Hi everyone, new to the forums and new to ScummVM :)

(macOS 13.2.1, ScummVM 2.7.0)

I have a strange behaviour when trying to play my two favourite childhood games: Broken Sword 1 and 2.

My folder structure for Broken Sword 1 (Windows CD) looks like:

Code: Select all

/gamedir/CLUSTERS/
-> contains all *.CLU and SWORDRES.RIF

/gamedir/MUSIC/
-> contains all .WAV except 2M29.WAV

/gamedir/SMACKSHI/
-> contains all .SMK

/gamedir/SPEECH/
-> contains both .CLF
When adding the gamedir for BS1, the game is properly detected and I am able to start the game. However, when I exit the game, quit ScummVM and with the next launch of ScummVM, BS1 is greyed out in the UI list and when trying to launch the game, I get an error pop-up with “Error running game: game data not found”. See screenshots for reference.

The exact same thing happens with Broken Sword 2. All required files for that game are in a single gamedir, the game is detected after adding, is playable after that and after the next exit and relaunch, it is also greyed out in the UI and cannot be started with the same error as BS1.

I have seen the note in the Wiki for BS1 (“Since ScummVM 2.7.0 the folder structure from the original media needs to be preserved”), but even with the subdirectories, this error occurs. I don’t think it is related since a specific folder structure is not required with BS2 and I am having this issue with the successor as well.

These are the only two games that have this issue, all other games I have added do not have this problem and are playable even with a restart of the ScummVM app.

So my question is: did I overlook something? Am I doing something wrong when adding BS1 and BS2?

Any help would be appreciated!
Attachments
game-data-not-found.png
game-data-not-found.png (9.96 KiB) Viewed 9228 times
broken_sword_ui.png
broken_sword_ui.png (80.63 KiB) Viewed 9228 times
Last edited by adventurefan on Sun Mar 26, 2023 8:38 am, edited 1 time in total.
User avatar
sev
ScummVM Lead
Posts: 2306
Joined: Wed Sep 21, 2005 1:06 pm
Contact:

Re: Broken Sword 1+2: game data not found after ScummVM restart

Post by sev »

adventurefan wrote: Sat Mar 25, 2023 8:29 pm So my question is: did I overlook something? Am I doing something wrong when adding BS1 and BS2?
The game gets greyed out when the game directory does not exist.

Could you please check what "gamepath" is written for your sword1 entry?

At least in the past, we had problems with some of the paths with UTF (non-Latin) characters, so check for that in the game path.


Eugene
User avatar
adventurefan
Posts: 10
Joined: Sat Mar 25, 2023 12:18 pm
Location: Germany

Re: Broken Sword 1+2: game data not found after ScummVM restart

Post by adventurefan »

sev wrote: Sat Mar 25, 2023 8:54 pm Could you please check what "gamepath" is written for your sword1 entry?

At least in the past, we had problems with some of the paths with UTF (non-Latin) characters, so check for that in the game path.
Thanks Eugene! I checked the path entries for both sword1 and sword2. This is how they get displayed in the the UI:

/Users/fabian/Personal/Emulation/ScummVM/Broken Sword - The Shadow of the Templars
/Users/fabian/Personal/Emulation/ScummVM/Broken Sword II - The Smoking Mirror

Blank spaces and/or dashes are no problem with other games I have added. There are no other weird characters I have used...
Attachments
path-sword1.jpg
path-sword1.jpg (48.96 KiB) Viewed 9218 times
User avatar
adventurefan
Posts: 10
Joined: Sat Mar 25, 2023 12:18 pm
Location: Germany

Re: Broken Sword 1+2: game data not found after ScummVM restart

Post by adventurefan »

Update: Solved! Made another test and changed the gamedirectory names to something without blank spaces or dashes (I used the ScummVM game ID as folder name):

"Broken Sword - The Shadow of the Templars" to "sword1"

and

"Broken Sword II - The Smoking Mirror" to "sword2"

For some reason this is working now and the game path is now detected across ScummVM restart. Again, I have other gamefolders where the root directory for the game contains either blank spaces or has a dash (e.g. /Monkey Island 2 - LeChuck's Revenge) and there were no issues, so I can only think of that in cases of BS1 and BS2 somehow an unknown character slipped into the folder name. I don't know how, but I'm glad it's working now! :) Will make sure to keep the path- and folder structure as simple as possible in the future.

Thanks for your help, Eugene!
User avatar
windh
Posts: 2
Joined: Wed Mar 14, 2018 7:04 pm

Re: [Solved] Broken Sword 1+2: game data not found after ScummVM restart

Post by windh »

Hi there.

I updated to 2.7.0 and then straight to 2.8.0 (hadn't updated SCUMMVM in a while). Running MacOS 13.2.1 at the moment.

Now I have the same issue with Broken Sword (1 and 2) just as described in this thread.

I have tried to change the name as described in the "solved" comment, but it won't fix it for me. I still cannot start the game with the same error as in the original post of this thread. I even tried to change the name of the game folder itself, but to no avail.

Any help would be greatly appreciated!

UPDATE: I re-installed the two versions from scratch and that fixed the issue. :mrgreen:
Nfsfan83
Posts: 29
Joined: Wed Mar 01, 2023 2:37 pm

Re: [Solved] Broken Sword 1+2: game data not found after ScummVM restart

Post by Nfsfan83 »

I still can't add good Broken Sword 1 to last Scummvm

I have Broken Sword 1 2x CD UK version, but with added Polish subtitles
User avatar
Praetorian
ScummVM Developer
Posts: 882
Joined: Tue May 08, 2007 8:54 am
Location: Greece
Contact:

Re: [Solved] Broken Sword 1+2: game data not found after ScummVM restart

Post by Praetorian »

Nfsfan83 wrote: Tue Apr 02, 2024 1:52 pm I still can't add good Broken Sword 1 to last Scummvm

I have Broken Sword 1 2x CD UK version, but with added Polish subtitles
Can you provide more details on this?
- What is the ScummVM version you're testing with?
- What is the exact error from ScummVM?
- Did you follow the *new* instructions on the wiki for the required data files and expected folder structure?
Nfsfan83
Posts: 29
Joined: Wed Mar 01, 2023 2:37 pm

Re: [Solved] Broken Sword 1+2: game data not found after ScummVM restart

Post by Nfsfan83 »

I send pics:

https://imgur.com/AVBTuk4

files in BS1 catalog on C:

https://imgur.com/xP24ajU

I test on last 2.7.0

Polish subtitles only change this file: text.clu

If I try change BS1 catalog to example sword1 I have this:

The game in 'sword1\' seems to be an unknown game variant.

Please report the following data to the ScummVM team at https://bugs.scummvm.org/ along with the name of the game you tried to add and its version, language, etc.:

Matched game IDs for the sword1 engine: sword1-demo-win

{"clusters/scripts.clu", 0, "72b10193714e8c6e4daca51791c0db0c", 1087240},
{"clusters/swordres.rif", 0, "31ea11161d5d2200b6b44a833b7d5aa8", 58916},
{"clusters/text.clu", 0, "7d9e47533fde5333dc310bfd73eaeb5c", 2666334},
{"smackshi/intro.smk", 0, "d82a7869ace8fcecaa519c04c4bfc483", 13233268},
User avatar
rootfather
ScummVM Lead
Posts: 182
Joined: Tue Mar 31, 2015 11:59 am
Location: Germany
Contact:

Re: [Solved] Broken Sword 1+2: game data not found after ScummVM restart

Post by rootfather »

In case you have a modified text.clu file, this behavior is expected since this file is part of the detection tables for the various BS games and thus must not be modified.
Nfsfan83
Posts: 29
Joined: Wed Mar 01, 2023 2:37 pm

Re: [Solved] Broken Sword 1+2: game data not found after ScummVM restart

Post by Nfsfan83 »

On earlier versions Scummvm works perfect ;) and I want play this lovely game with polish subtitles
User avatar
rootfather
ScummVM Lead
Posts: 182
Joined: Tue Mar 31, 2015 11:59 am
Location: Germany
Contact:

Re: [Solved] Broken Sword 1+2: game data not found after ScummVM restart

Post by rootfather »

Yes, because older versions accepted everything that looked remotely like a Broken Sword datafile. Since this caused _lots_ of issues due to bad or modified copies, we now follow the same strict principle as we do in the other games.

Modified versions are not supported anymore.
Nfsfan83
Posts: 29
Joined: Wed Mar 01, 2023 2:37 pm

Re: [Solved] Broken Sword 1+2: game data not found after ScummVM restart

Post by Nfsfan83 »

very sad, so you make newer version of Scummvm, who is worst than older:( weird. I very like 2.7.0 version because it have shaders, like old crt monitor.

Ok I will be used older version of Scummvm.

Ps. BS2 polish edition works perfect !!! on 2.7.0 (text.clue is polish) In Poland game from begin was selling like edition with polish subtitles

Ps2. using original text.clu for BS1 now game works fine :( but without polish text
User avatar
Praetorian
ScummVM Developer
Posts: 882
Joined: Tue May 08, 2007 8:54 am
Location: Greece
Contact:

Re: [Solved] Broken Sword 1+2: game data not found after ScummVM restart

Post by Praetorian »

Nfsfan83 wrote: Tue Apr 02, 2024 5:25 pm I send pics:

https://imgur.com/AVBTuk4

files in BS1 catalog on C:

https://imgur.com/xP24ajU

I test on last 2.7.0

Polish subtitles only change this file: text.clu

If I try change BS1 catalog to example sword1 I have this:

The game in 'sword1\' seems to be an unknown game variant.

Please report the following data to the ScummVM team at https://bugs.scummvm.org/ along with the name of the game you tried to add and its version, language, etc.:

Matched game IDs for the sword1 engine: sword1-demo-win

{"clusters/scripts.clu", 0, "72b10193714e8c6e4daca51791c0db0c", 1087240},
{"clusters/swordres.rif", 0, "31ea11161d5d2200b6b44a833b7d5aa8", 58916},
{"clusters/text.clu", 0, "7d9e47533fde5333dc310bfd73eaeb5c", 2666334},
{"smackshi/intro.smk", 0, "d82a7869ace8fcecaa519c04c4bfc483", 13233268},
Looking at our detection tables for BS1, we do have a Polish version supported (two actually, but one is the most similar to yours).
All files used in detection appear to be the same, except for the "swordres.rif" file.
https://github.com/scummvm/scummvm/blob ... les.h#L416

I wonder why the swordres.rif file is different in yours.
(There actually does not seem to be any entry in our detection table with that chechsum for the swordres.rif file)

Maybe it'd be worth it to open a bug ticket about this.
AndywinXp
ScummVM Developer
Posts: 29
Joined: Sun Jul 29, 2012 8:15 pm

Re: [Solved] Broken Sword 1+2: game data not found after ScummVM restart

Post by AndywinXp »

Hi! I fixed it, you should be able to play the game on tomorrow's daily version :D
Post Reply