Bug? in Monkey Island 1 EGA with Scummvm 2.8.0

[Wronschien]

Hello, I encountered a problem with latest version of Scummvm.
Just at the beginning of Monkey Island 1 EGA when you have to use the Dial a Pirate wheel, the input is VERY easily doubled. Actually after many tries, and letting the keys down as swiftly as possible, I couldn't manage to enter the code even once without doubling at least the 3rd digit, making it also the 4th and failing the test as you can't correct the last one.
I checked with previous version 2.7.1 and it works flawlessly, the input needs much more time to get doubled so no problem.

[Praetorian]

Hello, I encountered a problem with latest version of Scummvm.
Just at the beginning of Monkey Island 1 EGA when you have to use the Dial a Pirate wheel, the input is VERY easily doubled. Actually after many tries, and letting the keys down as swiftly as possible, I couldn't manage to enter the code even once without doubling at least the 3rd digit, making it also the 4th and failing the test as you can't correct the last one.
I checked with previous version 2.7.1 and it works flawlessly, the input needs much more time to get doubled so no problem.

Hello! Which platform are you running ScummVM on? Is this on Windows?

[Wronschien]

Yes, windows 10 x64
Btw, I'm testing the French version of the game, dunno if the English one also has the problem.

[tag2015]

i can reproduce the bug on the English version, I'm on Win10 too. But it only happens when using the numpad, using the standard keys everything seems normal.
I tried fiddling with the improvements on "game options", but doesn't seem to be related.

[Praetorian]

i can reproduce the bug on the English version, I'm on Win10 too. But it only happens when using the numpad, using the standard keys everything seems normal.
I tried fiddling with the improvements on "game options", but doesn't seem to be related.

I can confirm that this happens in 2.8.0 when using the numpad keys.
2.7.1 does indeed work without this issue.

I think this should be opened as a bug ticket on the tracker.
https://bugs.scummvm.org

[Praetorian]

Bisecting the code points to commit:
https://github.com/scummvm/scummvm/comm ... 1dad65ab0f "SCUMM: Fix remapping of numpad keys on EVENT_KEYUP"
as the offender for this.

Edit: I have opened a ticket on the bug tracker here:
https://bugs.scummvm.org/ticket/14781

[Wronschien]

Great news ! I'm glad I could help a bit.

[digitall]

For reference, this is now open as https://bugs.scummvm.org/ticket/14781

[digitall]

DOH! ... Just spotted Praetorian's edit As you were.