ScummVM 2.0.0 - Hanging notes with real MIDI synth

Digitoxin · Post by **Digitoxin** » Wed Dec 20, 2017 12:18 am

When using ScummVM 2.0.0 with a real MIDI tone generator (Yamaha MU-80), I get hanging notes when exiting ScummVM while playing Sierra SCI games. I haven't tried any other games yet.

Shouldn't ScummVM be sending a reset command to MIDI devices on exit to prevent this type of thing from happening?

Raziel · Post by **Raziel** » Wed Dec 20, 2017 7:07 am

You were probably hit by this.

Digitoxin · Post by **Digitoxin** » Wed Dec 20, 2017 7:34 am

Regardless of the engine being used, ScummVM should always send a reset command to the MIDI device on exit.

Raziel wrote:You were probably hit by this.

Raziel · Post by **Raziel** » Wed Dec 20, 2017 12:19 pm

As written in the link i posted there was a big rewrite of SCI's MIDI part which unfortunately broke some things.

One of them (probably) were the issues you are expereincing.

If you try 1.9.0 you'll see that it does what you expect it to do and it will again, in a future version/revision.

snover · Post by **snover** » Wed Dec 20, 2017 5:20 pm

There is an open bug report about this. The MPU-401 driver does seem to be sending some reset-looking messages when it is destroyed, and not everyone experiences this problem, so I can’t explain offhand why it might be happening to you. Providing more reproduction information in that ticket could be helpful.

Raziel wrote:As written in the link i posted there was a big rewrite of SCI's MIDI part which unfortunately broke some things.

This is actually the complete opposite of what I wrote in that thread.

Raziel · Post by **Raziel** » Wed Dec 20, 2017 5:29 pm

Yep, sorry...mixed up the fact that there is a big rewrite needed...too tired

Digitoxin · Post by **Digitoxin** » Thu Dec 21, 2017 12:11 am

I have several external MIDI devices so I'll do some extensive testing on this and post my results on the bug report.

snover wrote:There is an open bug report about this. The MPU-401 driver does seem to be sending some reset-looking messages when it is destroyed, and not everyone experiences this problem, so I can’t explain offhand why it might be happening to you. Providing more reproduction information in that ticket could be helpful.

Raziel wrote:As written in the link i posted there was a big rewrite of SCI's MIDI part which unfortunately broke some things.
This is actually the complete opposite of what I wrote in that thread.