How to integrate "kyra.dat"?

[corwin78]

Hello guys,
I am trying to implement Czech fan translation to Kyrandia 1 and Kyrandia 3 (Kyrandia 2 is working fine), but I am failed on MD5 checksum of course. I didn't found any way how to bypass it, so I am decided to modify detection_tables source code instead (let me say that I am not a programmer, more something like advanced user).

So, I am cloned ScummVM Git repo, and modified file "scummvm/engines/kyra/detection_tables.h" like follows:

Code: Select all

	{ // Czech fan translation
		{
			"kyra1",
			"CD",
			AD_ENTRY1("GEMCUT.PAK", "012c7cbff132e27d33d989c662086063"),
			Common::CS_CZE,
			Common::kPlatformDOS,
			ADGF_CD,
			GUIO4(GUIO_MIDIADLIB, GUIO_MIDIMT32, GUIO_MIDIPCSPK, GUIO_RENDERVGA)
		},
		KYRA1_CD_FAN_FLAGS(Common::CS_CZE, Common::EN_ANY)
	},

and

Code: Select all

	{ // Czech fan translation
		{
			"kyra3",
			0,
			AD_ENTRY1s("ONETIME.PAK", "951620e6298843e328bc745634373db5", AD_NO_SIZE),
			Common::CS_CZE,
			Common::kPlatformDOS,
			ADGF_DROPLANGUAGE,
			GUIO5(GUIO_NOMIDI, GUIO_RENDERVGA, GAMEOPTION_KYRA3_AUDIENCE, GAMEOPTION_KYRA3_SKIP, GAMEOPTION_KYRA3_HELIUM)
		},
		KYRA3_CD_FAN_FLAGS(Common::CS_CZE, Common::EN_ANY)
	},

and compiled my own ScummVM.

Now I can pass MD5 checksum but failing on "missing or corrupted" file "kyra.dat".

According to this information I am downloaded "kyra.dat" from here.

I am tried to place it to the folder with game files, to the folder with my compiled ScummVM executable file, and to the extrapath (where I have MT32 and GM SoundFonts too), but result is still the same, it is not working.

So, what am I doing wrong and how to solve it?

And why am I trying to do it? I am planning to submit request for adding MD5 checksum via bug tracker, but I want to be sure, that it is working correctly, before I will do it.

Thank you for any help.

[sev]

kyra.dat file is embedded in the executable on Windows, and if you put it along with the game files, that should pick it up.

What could happen here, however, is that it tries to search for Czech data in the kyra.dat and fails to do so.

The contents of the file are generated by the relevant program called create_kyradat, so for complete language support, the strings must be added to it. The code sits in https://github.com/scummvm/scummvm/tree ... te_kyradat

Then, we can regenerate kyra.dat and ship it with the next version of ScummVM.


Eugene

[corwin78]

Hello Eugene, thank you for response, I will try to dig in it.

Anyway, I forgot to mention that I am using Linux version.

[corwin78]

So, I am started with Kyrandia 3, because there is not much things to change, regarding translation.

I am created file "devtools/create_kyradat/resources/mr_dos_cd_czech.h" with localizes strings and modified following files:

• "engines/kyra/detection_tables.h" - Added game description for Czech fan version - see my first post for details.
• "devtools/create_kyradat/games.cpp" - Added:

  Code: Select all

  const Game kyra3Games[] = {
          ...
          { kKyra3, kPlatformDOS, kTalkieVersion, CS_CZE },
          ...
  };

• "devtools/create_kyradat/resources.cpp" - Added:

  Code: Select all

  #include "resources/mr_dos_cd_czech.h"

  and Kyra 3 related strings under Resource providers.

ScummVM compiling is successfull, but unfortunately I still getting error message: "You're missing the 'KYRA.DAT' engine data file or it got corrupted."

Any advice how to continue?

[athrxx]

You could make a pull request with your detection and kyra.dat changes.
And also provide a link to the Czech fan translation patch.
I could then add the necessary code to finish this up.

[corwin78]

You could make a pull request with your detection and kyra.dat changes.
And also provide a link to the Czech fan translation patch.
I could then add the necessary code to finish this up.

OK, thank you. So, I will take care about Kyra 1 and Kyra 2 modification and then I will do what you are recommending.

[corwin78]

You could make a pull request with your detection and kyra.dat changes.
And also provide a link to the Czech fan translation patch.
I could then add the necessary code to finish this up.

Hello, I am created pull request #6519.